This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Prevent kicking users who aren't in the room #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Apr 3, 2019
|
I wonder whether it'd be worth rewriting this so that we specifically said what transitions were allowed, rather than adding ad hoc rules. |
|
Could do, yeah. |
|
Although we're going to want custom error messages for what isn't allowed, which may end up looking quite close to the current code anyways. |
Codecov Report
@@ Coverage Diff @@
## develop #4999 +/- ##
===========================================
- Coverage 60.7% 60.69% -0.01%
===========================================
Files 332 332
Lines 34172 34176 +4
Branches 5633 5635 +2
===========================================
Hits 20743 20743
- Misses 11958 11960 +2
- Partials 1471 1473 +2 |
|
Left a TODO. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent kick events from succeeding if the user is not currently in the room.
Closes #4973
Sytest PR: matrix-org/sytest#602